Re: [PATCH] Remove Powerpc OProfile events the kernel will reject
William Cohen <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
Re sendind to include Michael Petlan on the email. -Will On 11/23/2015 09:47 AM, William Cohen wrote: > On 11/21/2015 06:58 PM, 大平怜 wrote: >> Carl, >> >> Could you take a look at the question I asked in the previous email? >> >>> I have a question about your patch. Your patch removed >>> PM_DATA_ALL_FROM_RL2L3_MOD, but this event does not >>> cause any error when I specify it to a previous version of OProfile. >>> Why does your patch have to remove this event? Maybe it depends >>> on the environment? I confirmed PM_L2_LD_MISS did cause an error, >>> as Chencheng Ye found. I have not yet checked the other events. >> >> >> Thanks, >> Rei Odaira > > Hi, > > I have included Michael Petlan on this discussion. When going through the x86 event he had some scripts that would check each of the events in perf to check to see if they could be set up and whether oprofile and perf got similar measurements for the experiments. I would imagine this framework would be useful for going through the power8 events to ensure that we are not needlessly disabling power8 events. > > -Will >> >> 2015-11-19 15:44 GMT-06:00 William Cohen <[email protected] <mailto:[email protected]>>: >> >> On 11/19/2015 04:00 PM, Carl E. Love wrote: >> > On Thu, 2015-11-19 at 15:13 -0500, William Cohen wrote: >> >> >> >> >> Remove unused Power 8 unit masks >> >> >> >> To prevent people from using PMU events that the kernel would reject >> >> on Power 8 commit 34715734fd6f commented out those events. However, >> >> additional checks in oprofile code would note that some of the unit >> >> masks were unused due to those commented out events and prevent >> >> oprofile tools from running. The unused unit masks have been >> >> commented out to pass these checks. >> >> >> >> Signed-off-by: William Cohen <[email protected] <mailto:[email protected]>> >> >> >> > Looks good. Thanks. >> > >> > Carl Love >> >> >> Okay. the patch is checked in and things should work on Power 8. >> >> -Will >> >> >> >> >> ------------------------------------------------------------------------------ >> >> >> >> _______________________________________________ >> oprofile-list mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/oprofile-list >> > > > ------------------------------------------------------------------------------ > Go from Idea to Many App Stores Faster with Intel(R) XDK > Give your users amazing mobile app experiences with Intel(R) XDK. > Use one codebase in this all-in-one HTML5 development environment. > Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. > http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 > _______________________________________________ > oprofile-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/oprofile-list > ------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741551&iu=/4140 _______________________________________________ oprofile-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oprofile-list