Re: [PATCH] Remove Powerpc OProfile events the kernel will reject

On 12/14/2015 05:18 PM, Carl E. Love wrote:
> Will, Rei:
> 
> As I suspected in the last email, there is a second issue that has to do
> with what version of the libpfm library OProfile is using.  Initially a
> subset of the OProfile events for Power 8 were added to libpfm4.5.
> Later the complete set of events was added to libpfm4.6.  So, My first
> attempt at removing the events that perf was rejecting inadvertently
> included events that were in libpfm 4.6 but not libpfm 4.5.  My version
> of oprofile was used a patched version of libpfm 4.4 that effectively
> made it libpfm 4.5.  I redid the patch an verified that when Oprofile is
> built with libpfm 4.6 there are no rejected events.  I added a comment
> in the event file as a heads up to this effect.  
> 
> Please take a look at the patch and see if it works OK for you.  Sorry
> for the delay in getting this out.
> 
>            Carl Love

Hi Carl,

Thanks for the updated patch.  You mentioned patched versions of libpfm.  Is this the libpfm in rhel7.  If it is the libpfm in rhel7, are there updates that need to be made to the version?

What environment being used to test?  Any testing on fedora 23 which has libpfm-4.6?

I did a quick check on an fedora 23 x86_64 machine with the following to make sure didn't encounter any problems with missing/unused unit masks :

ophelp -c ppc64/power8

That worked and the patch itself looks okay, so I am comfortable checking in the patch. 

Rei, any additional comments about the patch?

-Will

------------------------------------------------------------------------------