Re: [PATCH] Remove Powerpc OProfile events the kernel will reject
William Cohen <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
On 12/17/2015 04:14 PM, 大平怜 wrote: > Hi Carl, Will, > > After applying the new patch, I confirmed all of the events accepted by my POWER8 were enabled and all of the events rejected were disabled. Thanks! > > > Rei Odaira Hi Carl and Rei, Thanks very much for the patch and the patch testing. I have applied the patch, so it is now in the upstream oprofile git repository. -Will > > 2015-12-16 10:25 GMT-06:00 William Cohen <[email protected] <mailto:[email protected]>>: > > On 12/16/2015 11:12 AM, Carl E. Love wrote: > > On Tue, 2015-12-15 at 17:33 -0500, William Cohen wrote: > >> On 12/14/2015 05:18 PM, Carl E. Love wrote: > >>> Will, Rei: > >>> > >>> As I suspected in the last email, there is a second issue that has to do > >>> with what version of the libpfm library OProfile is using. Initially a > >>> subset of the OProfile events for Power 8 were added to libpfm4.5. > >>> Later the complete set of events was added to libpfm4.6. So, My first > >>> attempt at removing the events that perf was rejecting inadvertently > >>> included events that were in libpfm 4.6 but not libpfm 4.5. My version > >>> of oprofile was used a patched version of libpfm 4.4 that effectively > >>> made it libpfm 4.5. I redid the patch an verified that when Oprofile is > >>> built with libpfm 4.6 there are no rejected events. I added a comment > >>> in the event file as a heads up to this effect. > >>> > >>> Please take a look at the patch and see if it works OK for you. Sorry > >>> for the delay in getting this out. > >>> > >>> Carl Love > > > >> Hi Carl, > >> > >> Thanks for the updated patch. You mentioned patched versions of libpfm. Is this the libpfm in rhel7. If it is the libpfm in rhel7, are there updates that need to be made to the version? > >> > >> What environment being used to test? Any testing on fedora 23 which has libpfm-4.6? > > > > Will: > > > > My system is Ubuntu 14.04. If you go look > > in /usr/lib/powerpc64le-linux-gnu/libpfm.so -> libpfm.so.4.4.0 it says > > 4.4. I know from working with them that the pulled patches from > > upstream for the release. When I tried running a script with all of the > > events in oprofile, only the events in the 4.5 release succeeded. > > Unfortunately, I am not up on specifically what packages all of the > > releases used an how many of the patches were back ported. > > > > Unfortunately, I do not have a system with Fedora 23 to test with. The > > only testing I could do with libpfm 4.6 was on my Unbuntu 14.04 system > > where I installed libpfm4.6 then built and installed OProfile using > > libpfm4.6. The new version of OProfile was put in /usr/local/bin. This > > allowed me to test against the distro installed OProfile and my libpfm > > 4.6 version on the same machine. > > > > It would be nice if we could get some testing on a distro that has 4.6 > > as part of the release. I expect that my team will probably updating > > the lab machines early next year and I can then double check then. > > > > Carl Love > > > > > Thanks for the information, Carl. RHEL7 had libpfm-4.4 with patch, so that was the reason for the question. There have also been some people running fedora 22 on power8 (https://bugzilla.redhat.com/show_bug.cgi?id=1290998) which has the libpfm-4.4. They are moving to testing on fedora23 which has libpfm-4.6 > > There is some information about fedora on ppc64 as secondary architecture at https://fedoraproject.org/wiki/Architectures/PowerPC > Also a page on the f22 ppc64 release at https://fedoraproject.org/wiki/PowerPC/F22/Installation > > -Will > > ------------------------------------------------------------------------------ _______________________________________________ oprofile-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oprofile-list