Re: misc oprofile-tests updates
Michael Petlan <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <alpine.LRH.2.20.1604011702341.7107@Rudolf-RHEL-7> |
On Wed, 30 Mar 2016, Will Schmidt wrote: > Hi Oprofile devs, > > A handful of changes to the oprofile-tests suite, for consideration. > > I stumbled across an issue while running the tests, dug in a bit, and came > out with this short series of patches to improve things. Most of the > changes are cosmetic, but a couple will affect the suite behavior, most > notably that more of the tests will be runnable as a normal user, and we > will successfully run more tests as root when the kptr_restrict mode is > in restricted mode, where we previously would have punted. (Additional > detail in the patch descriptions.) > > I've tested these changes against an older (0.9.8) install, as well as > against latest (1.2.0git), no new issues in my testing. > > As a user: > before: 49/49 tests passed. > after: 74/78 to 78/78 tests passed. (depending on the value of kptr_restrict) > > As root: > No notable changes. My latest run showed > after: 113/117 to 117/117 tests passed. (depending on kptr_restrict) > > Thanks, > -Will > Hi, I have run the testsuite with your patches on a few machines and I like the changes. Thank you for them. I am interested in the failures related to the value of kptr_restrict. Could you please provide more information about your testing? Which kptr_restrict values it passes with? Which values it fails with? Which kernel versions, archs, systems have you used? I have met an issue with incorrect kallsyms detection (see the patch I have sent recently). I noticed that issue by running the patched suite where it was reporting "set kptr_restrict to 0" despite having it 0. Also please try to run grep -e ' _stext' -e ' _text' -e ' _etext' /proc/kallsyms on the box(es) where you tested the suite and send the output. In case your kernel's kallsyms file has the _stext symbol, could you also try to run the tests against oprofile with my patch if anything changes. Thank you! Michael > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 > _______________________________________________ > oprofile-list mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/oprofile-list > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140