Re: [PATCH] oprofile: Add support for Goldmont events
Andi Kleen <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
William Cohen <[email protected]> writes: >>> >>>> + 0x1 extra: hit Counts each cache line access to the Icache that are fulfilled (hit) by the Icache >>>> + 0x2 extra: misses Counts each cache line access to the Icache that are not fullfilled (miss) by the Icache >>>> + 0x3 extra: accesses Counts each cache line access to the Icache >>>> +name:inst_retired type:exclusive default:any >>>> + 0x0 extra: any Counts the number of instructions that retire >>>> execution. For instructions that consist of multiple uops, this >>>> event counts the retirement of the last uop of the >>>> instruction. The counter continues counting during hardware >>>> interrupts, traps, and inside interrupt handlers. This event uses >>>> fixed counter 0. You cannot collect a PEBs record for this event >>>> + 0x0 extra: any_p Counts the number of instructions that retire >>>> execution. For instructions that consist of multiple uops, this >>>> event counts the retirement of the last uop of the >>>> instruction. The event continues counting during hardware >>>> interrupts, traps, and inside interrupt handlers. This is an >>>> architectural performance event. This event uses a >>>> (_P)rogrammable general purpose performance counter. *This event >>>> is Precise Event capable: The EventingRIP field in the PEBS record >>>> is precise to the address of the instruction which caused the >>>> event. Note: Because PEBS records can be collected only on >>>> IA32_PMC0, only one event can use the PEBS facility at a time. >>> >>> Doesn't the any_p version need to be split into two unit masks? One >>> for normal programmable counter use (any_p) and another for pebs >>> use (any_pebs)? >> >> Right one for PEBS, another without. > > The updated patch does not have the any_pebs version for inst_retired. > Shouldn't there be a line for inst_retired umask like the following in > there? Yes. I'll add one. -Andi -- [email protected] -- Speaking for myself only ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z