Re: [PATCH] s390: Add support for z13

On Wed, 12 Oct 2016, William Cohen wrote:
> On 10/12/2016 10:01 AM, Michael Petlan wrote:
>> On Wed, 5 Oct 2016, Andreas Arnez wrote:
>>>
>>> IIRC, I just performed a quick smoke test before submitting this patch;
>>> and oprofile didn't crash.  Other than that, I don't really know what
>>> works and what doesn't.
>>>
>
> Hi Andreas and Andreas,
>
> Is there support for IBM z13 perf counters in the upstream linux kernel?  I didn't see perf support for IBM z13 in the mainline kernel git repository.
>
> There is a difference between the kernel and oprofile is the s390 identification.  The kernel is using hex numbers such as 0x2817 and 0x2818 for Z196 identification (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/s390/kernel/perf_cpum_cf_events.c#n303), but oprofile is reading the numbers as decimal for idenfication (https://sourceforge.net/p/oprofile/oprofile/ci/master/tree/libop/op_cpu_type.c).  oprofile should also be using hex numbers like the kernel.

I have looked at this and although it is not ideal, it works OK in OProfile,
since it reads the numbers from string, thus it works with decimals.

I have also checked that zEC12 detection works correctly with 1.1.

Michael

>
> -Will
>>