Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn
Emil Velikov <[email protected]>
| Newsgroups | gmane.linux.kernel.virtualization,gmane.linux.ports.ia64,gmane.linux.ports.sh.devel,gmane.comp.freedesktop.xorg.nouveau,gmane.linux.alsa.devel,gmane.comp.video.dri.devel,gmane.linux.ide,gmane.linux.drivers.mtd,gmane.linux.ports.sparc,gmane.linux.kernel.drbd.devel,gmane.linux.ports.arm.omap,gmane.linux.scsi,gmane.comp.boot-loaders.tboot.devel,gmane.comp.freedesktop.amd-gfx,gmane.linux.acpi.devel,gmane.linux.oprofile,gmane.linux.kernel.input,gmane.linux.drivers.video-input-infrastructure,gmane.linux.drivers.devicetree,gmane.linux.acpi.acpi4asus.user,gmane.linux.drivers.platform.x86.devel,gmane.linux.ports.arm.kernel,gmane.linux.network,gmane.linux.kernel,gmane.linux.kernel.cryptoapi,gmane.linux.ports.alpha,gmane.linux.ports.ppc64.devel |
|---|---|
| Message-ID | <CACvgo50LUm5VSn_F=Dh8kL5zCPpCQDoCyUEL=Z+=1+6hJpfTaw@mail.gmail.com> |
On 23 February 2017 at 17:18, Joe Perches <[email protected]> wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <[email protected]> wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source tree. >> > >> > Make the use of pr_warn consistent across all kernel files. >> > >> > This excludes all files in tools/ as there is a separate >> > define pr_warning for that directory tree and pr_warn is >> > not used in tools/. >> > >> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > [] >> Where's the removal of pr_warning so we don't have more sneak in? > > After all of these actually get applied, > and maybe a cycle or two later, one would > get sent. > By which point you'll get a few reincarnation of it. So you'll have to do the same exercise again :-( I guess the question is - are you expecting to get the series merged all together/via one tree ? If not, your plan is perfectly reasonable. Fwiw in the DRM subsystem, similar cleanups does purge the respective macros/other with the final commit. But there one can pull the lot in one go. Regards, Emil