Re: [PATCH] avr32: Fix build error caused by include file reshuffling
Hans-Christian Noren Egtvedt <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.oprofile |
|---|---|
| Message-ID | <[email protected]> |
Around Sun 05 Mar 2017 17:05:57 -0800 or thereabout, Guenter Roeck wrote:
> Various avr32 builds fail as follows.
>
> arch/avr32/oprofile/backtrace.c:58: error:
> dereferencing pointer to incomplete type
> arch/avr32/oprofile/backtrace.c:60: error:
> implicit declaration of function 'user_mode'
>
> Fixes: f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from ...")
> Cc: Ingo Molnar <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>
Acked-by: Hans-Christian Noren Egtvedt <[email protected]>
> ---
> Please feel free to ignore if av32 is going to be removed.
AVR32 is not going away for 4.11, we started the FYI and review process too
late to make the window.
I think I will push it, to make sure AVR32 leaves the kernel in as good state
as possible.
> arch/avr32/oprofile/backtrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/oprofile/backtrace.c b/arch/avr32/oprofile/backtrace.c
> index 75d9ad6f99cf..29cf2f191bfd 100644
> --- a/arch/avr32/oprofile/backtrace.c
> +++ b/arch/avr32/oprofile/backtrace.c
> @@ -14,7 +14,7 @@
> */
>
> #include <linux/oprofile.h>
> -#include <linux/sched.h>
> +#include <linux/ptrace.h>
> #include <linux/uaccess.h>
>
> /* The first two words of each frame on the stack look like this if we have
--
mvh
Hans-Christian Noren Egtvedt