Re: OProfile-1.2.0-rc1

On 06/26/2017 10:42 AM, Will Schmidt wrote:
> On Mon, 2017-06-19 at 11:08 -0400, William Cohen wrote:
>> There have been a number of improvements checked into the OProfile git repo.  It would be good to have those into an official release.  I have made a release candidate and it would be good to test this out on various platforms.
>>
>> URL:
>> https://sourceforge.net/projects/oprofile/files/oprofile/oprofile-1.2.0rc1/oprofile-1.2.0rc1.tar.gz/download
>>
> 
> I grabbed and did a build/run across a small assortment of power
> systems.   (power7,power8LE,power8BE), test suite runs clean. 
> (Also looks good on pre-ga P9)
> 			=== oprofile Summary ===
> 	
> 	# of expected passes		78
> 
> One error in 'make check'.  (also see this on my x86 laptop).
> I suspect not a big deal, but in case... :-)
> 
> 	FAIL: load_events_files_tests
> 
> 	um zero is not used
> 
> A quick peek via gdb suggests this is occurring when trying to parse the
> events files for CPU_CORE_I7, down the op_events(cpu_type) path.  If I
> force that test to pass via setting err=0 in gdb, it occurs again on
> CPU_NEHALEM.
> 
> Breakpoint 1, op_events (cpu_type=CPU_CORE_I7) at op_events.c:724
> 724	{
> $60 = CPU_CORE_I7
> um zero is not used
> 
> Breakpoint 1, op_events (cpu_type=CPU_NEHALEM) at op_events.c:724
> 724	{
> $63 = CPU_NEHALEM
> um zero is not used
> 
> 
> thanks
> -Will (Schmidt)

Hi Will,

I took a look at this failure from "make check".  This is due to the events/i386/arch_perfmon/unit_masks having the unit mask zero, but it not being used in nahelem for the events. i386/nehalem/events has:

#event:0x3c counters:0,1,2,3 um:zero minimum:6000 name:CPU_CLK_UNHALTED : Clock cycles when not halted
event:0x3c counters:0,1,2,3 um:one minimum:6000 name:UNHALTED_REFERENCE_CYCLES : Unhalted reference cycles

The nahelem events are included in the i386/core_i7 events. Thus, it also suffers from the same problem.  This appears to be relatively harmless.  However, it does cause the load_events_files_tests test to abort so processors after core_i7 (including nehalem) are not check for event sanity.  I manually set err=0 after each of the reports of the unused mask and didn't see any other problems.

-Will Cohen

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot