Re: 答复: Can OProfile support reproducible build?
Michael Petlan <[email protected]>
| Newsgroups | gmane.linux.oprofile |
|---|---|
| Message-ID | <alpine.LRH.2.20.1708311706560.13365@Diego> |
Hi, On Thu, 31 Aug 2017, William Cohen wrote: > Hi, > > It would be fine to have a patch that strips out those things that prevent the build from being reproducible. Both Fedora and Debian are have talked about moving towards reproducible builds: ... something like the attached one? Btw. I was trying to find where in doc the version string is documented and I found nothing... > > https://reproducible.alioth.debian.org/presentations/2017-01-27-devconf.cz-reproducible-builds+fedora.pdf > https://wiki.debian.org/ReproducibleBuilds/About > https://fedoraproject.org/wiki/Changes/RPM-4.14 > > -Will > > > > > On Thu, 31 Aug 2017, Zhongwenlin wrote: > >> Thank you. > >> I tried to replace the time stamps __DATE__ and __TIME__ macros by a fixed time string, and it works. > >> Can Oprofile add configurations or just remove the time stamps(if they are not necessary ) in future versions? > >> > >> -----邮件原件----- > >> 发件人: Michael Petlan [mailto:[email protected]] > >> 发送时间: 2017年8月30日 22:35 > >> 收件人: Zhongwenlin > >> 抄送: William Cohen; Gaokun (King); [email protected] > >> 主题: RE: Can OProfile support reproducible build? > >> > >> Well, if just these three points are the whole show-stopper, we might make them conditional like > >> > >> #ifdef REPRODUCIBLE_BUILD > >> cout << argv[0] << ": " << PACKAGE << " " << VERSION << endl; #else // the original stuff #endif > >> > >> ... or just remove the timestamps entirely... > >> > >> If you replace the __DATE__ and __TIME__ macros there by some dummy string, does it build reproducibly? > >> > >> Michael > >> > >> On Wed, 30 Aug 2017, Zhongwenlin wrote: > >>> Hi, > >>> I use the latest version 1.2.0. And I found that the code below would generate timestamps----just they cause the difference. > >>> How > >>> > >>> libutil/op_version.c: > >>> 21: printf("%s: " PACKAGE " " VERSION " compiled on " > >>> 22：__DATE__ " " __TIME__ "\n", app_name); > >>> > >>> pe_counting/ocount.cpp: > >>> 659: case 'v': > >>> 660: cout << argv[0] << ": " << PACKAGE << " " << VERSION << " compiled on " << __DATE__ > >>> 661:<< " " << __TIME__ << endl; > >>> > >>> pe_profiling/operf.cpp: > >>> 1344:case 'v': > >>> 1345:cout << argv[0] << ": " << PACKAGE << " " << VERSION << " compiled on " << __DATE__ > >>> 1346:<< " " << __TIME__ << endl; > >>> > >>> How can I eliminate the timestamps? > >>> > >>> > >>> -----邮件原件----- > >>> 发件人: William Cohen [mailto:[email protected]] > >>> 发送时间: 2017年8月29日 2:14 > >>> 收件人: [email protected]; Zhongwenlin > >>> 抄送: Gaokun (King) > >>> 主题: Can OProfile support reproducible build? > >>> > >>> From [email protected]: > >>> > >>> > >>> Hi, > >>> > >>> When I build Oprofile, I find the build results are different every time. It seems to be caused by some time stamps. How can I get rid of the time stamps? > >>> > >>> As we know, reproducible build is a good way to counter malicious attacks that generate malicious executables, by making it easy to recreate the executable to determine if the result is correct. How can I eliminate the differences caused by the time stamps? Just remove some code? Or is there any configuration? > >>> > >>> Can Oprofile support reproducible build in later versions? > >>> > >>> Thank you. > >>> > >>> > >>> > >>> --------------- > >>> > >>> > >>> Hi, > >>> > >>> It would be helpful to describe in more detail which version of OProfile is being built, how OProfile is being built, and specific differences between the repeated builds. > >>> > >>> Debian does have some information on techniques on indentify reproducible build issues and ways to address them: > >>> > >>> https://wiki.debian.org/ReproducibleBuilds/Howto > >>> > >>> -Will > >>> ---------------------------------------------------------------------- > >>> -------- Check out the vibrant tech community on one of the world's > >>> most engaging tech sites, Slashdot.org! http://sdm.link/slashdot > >>> _______________________________________________ > >>> oprofile-list mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/oprofile-list > >>> > > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ oprofile-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/oprofile-list
reproducible.patch
(text/plain, 1.7 KB)
commit ca561679cc3bb76e0b9885f87b98a01ad716910b Author: Michael Petlan <[email protected]> Date: Thu Aug 31 17:05:05 2017 +0200 Remove timestamps from version strings to enable reproducible building diff --git a/libutil/op_version.c b/libutil/op_version.c index 99a844e..f335af3 100644 --- a/libutil/op_version.c +++ b/libutil/op_version.c @@ -18,7 +18,6 @@ void show_version(char const * app_name) { /* Do not change the version format: it is documented in html doc */ - printf("%s: " PACKAGE " " VERSION " compiled on " - __DATE__ " " __TIME__ "\n", app_name); + printf("%s: " PACKAGE " " VERSION "\n", app_name); exit(EXIT_SUCCESS); } diff --git a/pe_counting/ocount.cpp b/pe_counting/ocount.cpp index 7717717..0a6fdd8 100644 --- a/pe_counting/ocount.cpp +++ b/pe_counting/ocount.cpp @@ -657,8 +657,7 @@ static int _process_ocount_and_app_args(int argc, char * const argv[]) __print_usage_and_exit(NULL); break; case 'v': - cout << argv[0] << ": " << PACKAGE << " " << VERSION << " compiled on " << __DATE__ - << " " << __TIME__ << endl; + cout << argv[0] << ": " << PACKAGE << " " << VERSION << endl; exit(EXIT_SUCCESS); break; default: diff --git a/pe_profiling/operf.cpp b/pe_profiling/operf.cpp index 06a0ea3..46b37a3 100644 --- a/pe_profiling/operf.cpp +++ b/pe_profiling/operf.cpp @@ -1342,8 +1342,7 @@ static int _process_operf_and_app_args(int argc, char * const argv[]) __print_usage_and_exit(NULL); break; case 'v': - cout << argv[0] << ": " << PACKAGE << " " << VERSION << " compiled on " << __DATE__ - << " " << __TIME__ << endl; + cout << argv[0] << ": " << PACKAGE << " " << VERSION << endl; exit(EXIT_SUCCESS); break; default: