Re: [PATCH v3 02/22] compat: provide compat_ptr() on all architectures
Arnd Bergmann <[email protected]> Tue, 7 Jan 2020 09:08:31 +0100
| Newsgroups | gmane.linux.kernel,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.ppc64.devel,gmane.linux.oprofile,gmane.linux.ports.sparc |
|---|---|
| Message-ID | <CAK8P3a17GshP1KmCpvCkWGDGJLC_JrGUFQZTLbfe5+sSwTjyxw@mail.gmail.com> |
On Tue, Jan 7, 2020 at 3:05 AM Michael Ellerman <[email protected]> wrote: > Arnd Bergmann <[email protected]> writes: > > + > > +static inline compat_uptr_t ptr_to_compat(void __user *uptr) > > +{ > > + return (u32)(unsigned long)uptr; > > +} > > Is there a reason we cast to u32 directly instead of using compat_uptr_t? Probably Al found this to be more explicit at the time when he introduced it on all the architectures in 2005. I just moved it here and kept the definition. Arnd