Re: [PATCH v4 7/9] parisc/perf: open access for CAP_SYS_PERFMON privileged process

Helge Deller <[email protected]> Mon, 27 Jan 2020 09:52:10 +0100
Newsgroups gmane.linux.ports.arm.kernel,gmane.linux.oprofile,gmane.comp.freedesktop.xorg.drivers.intel,gmane.linux.ports.parisc,gmane.linux.kernel,gmane.linux.kernel.perf.user,gmane.linux.kernel.lsm,gmane.linux.ports.ppc64.devel
Message-ID <[email protected]>
On 18.12.19 10:29, Alexey Budankov wrote:
>
> Open access to monitoring for CAP_SYS_PERFMON privileged processes.
> For backward compatibility reasons access to the monitoring remains open
> for CAP_SYS_ADMIN privileged processes but CAP_SYS_ADMIN usage for secure
> monitoring is discouraged with respect to CAP_SYS_PERFMON capability.
>
> Signed-off-by: Alexey Budankov <[email protected]>

Acked-by: Helge Deller <[email protected]>

> ---
>  arch/parisc/kernel/perf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/parisc/kernel/perf.c b/arch/parisc/kernel/perf.c
> index 676683641d00..c4208d027794 100644
> --- a/arch/parisc/kernel/perf.c
> +++ b/arch/parisc/kernel/perf.c
> @@ -300,7 +300,7 @@ static ssize_t perf_write(struct file *file, const char __user *buf,
>  	else
>  		return -EFAULT;
>
> -	if (!capable(CAP_SYS_ADMIN))
> +	if (!perfmon_capable())
>  		return -EACCES;
>
>  	if (count != sizeof(uint32_t))
>