Re: [PATCH 6/8] simplefs: add file creation functions

Greg Kroah-Hartman <[email protected]> Tue, 14 Apr 2020 14:56:26 +0200

Newsgroups	gmane.linux.oprofile,gmane.linux.usb.general,gmane.comp.video.dri.devel,gmane.linux.network,gmane.comp.file-systems.ocfs2.devel,gmane.linux.kernel.efi,gmane.linux.drivers.rdma,gmane.linux.kernel.autofs,gmane.linux.file-systems,gmane.linux.nfs,gmane.linux.scsi,gmane.linux.kernel.mm,gmane.linux.kernel.lsm,gmane.linux.kernel,gmane.linux.ports.ppc64.devel
Message-ID	<[email protected]>

On Tue, Apr 14, 2020 at 02:43:00PM +0200, Emanuele Giuseppe Esposito wrote:
> A bunch of code is duplicated between debugfs and tracefs, unify it to the
> simplefs library.
> 
> The code is very similar, except that dentry and inode creation are unified
> into a single function (unlike start_creating in debugfs and tracefs, which
> only takes care of dentries).  This adds an output parameter to the creation
> functions, but pushes all error recovery into fs/simplefs.c.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <[email protected]>
> ---
>  fs/simplefs.c            | 150 +++++++++++++++++++++++++++++++++++++++
>  include/linux/simplefs.h |  19 +++++
>  2 files changed, 169 insertions(+)

What's wrong with libfs, isn't that supposed to be for these types of
"common" filesystem interactions?

Why create a whole "new" fs for this?

thanks,

greg k-h