Re: [PATCH 6/8] simplefs: add file creation functions
Paolo Bonzini <[email protected]> Mon, 20 Apr 2020 16:33:04 +0200
| Newsgroups | gmane.linux.oprofile,gmane.linux.usb.general,gmane.comp.video.dri.devel,gmane.linux.network,gmane.comp.file-systems.ocfs2.devel,gmane.linux.kernel.efi,gmane.linux.drivers.rdma,gmane.linux.kernel.autofs,gmane.linux.file-systems,gmane.linux.nfs,gmane.linux.scsi,gmane.linux.kernel.mm,gmane.linux.kernel.lsm,gmane.linux.kernel,gmane.linux.ports.ppc64.devel |
|---|---|
| Message-ID | <[email protected]> |
On 20/04/20 16:28, Greg Kroah-Hartman wrote: >> I assume you meant a new file. These new functions are used only by a few >> filesystems, and I didn't want to include them in vmlinux unconditionally, >> so I introduced simplefs.c and CONFIG_SIMPLEFS instead of extending libfs.c. >> In this way only fs that need this code like debugfs and tracefs will load >> it. > Nothing "loads it", why not just make these libfs functions instead? As > the difference between the two is not obvious at all, please don't make > things confusing. I think Emanuele meant "will link it" not "will load it". Emanuele, you can just move everything to libfs.c and get rid of CONFIG_SIMPLEFS too. "Do less" is not an offer you want to turn down! Thanks, Paolo