Re: [PATCH 2/8] fs: extract simple_pin/release_fs to separate files

Emanuele Giuseppe Esposito <[email protected]> Tue, 21 Apr 2020 13:26:43 +0200

Newsgroups	gmane.linux.ports.ppc.embedded,gmane.linux.nfs,gmane.linux.usb.general,gmane.comp.video.dri.devel,gmane.linux.network,gmane.linux.kernel.efi,gmane.linux.drivers.rdma,gmane.linux.oprofile,gmane.linux.kernel.autofs,gmane.linux.scsi,gmane.linux.kernel.mm,gmane.linux.kernel.lsm,gmane.linux.kernel,gmane.linux.file-systems,gmane.comp.file-systems.ocfs2.devel
Message-ID	<[email protected]>


On 4/21/20 1:19 PM, Frederic Barrat wrote:
>=20
>=20
>> diff --git a/drivers/misc/cxl/Kconfig b/drivers/misc/cxl/Kconfig
>> index 39eec9031487..a62795079d9c 100644
>> --- a/drivers/misc/cxl/Kconfig
>> +++ b/drivers/misc/cxl/Kconfig
>> @@ -19,6 +19,7 @@ config CXL
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select CXL_BASE
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select CXL_AFU_DRIVER_OPS
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select CXL_LIB
>> +=C2=A0=C2=A0=C2=A0 select SIMPLEFS
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default m
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 help
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Select this option to enable =
driver support for IBM Coherent
>> diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
>> index b493de962153..0b8f8de7475a 100644
>> --- a/drivers/misc/cxl/api.c
>> +++ b/drivers/misc/cxl/api.c
>> @@ -9,6 +9,7 @@
>> =C2=A0 #include <misc/cxl.h>
>> =C2=A0 #include <linux/module.h>
>> =C2=A0 #include <linux/mount.h>
>> +#include <linux/simplefs.h>
>> =C2=A0 #include <linux/pseudo_fs.h>
>> =C2=A0 #include <linux/sched/mm.h>
>> =C2=A0 #include <linux/mmu_context.h>
>> diff --git a/drivers/misc/ocxl/Kconfig b/drivers/misc/ocxl/Kconfig
>> index 2d2266c1439e..ddd9245fff3d 100644
>> --- a/drivers/misc/ocxl/Kconfig
>> +++ b/drivers/misc/ocxl/Kconfig
>> @@ -12,6 +12,7 @@ config OCXL
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 depends on PPC_POWERNV && PCI && EEH
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select OCXL_BASE
>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 select HOTPLUG_PCI_POWERNV
>> +=C2=A0=C2=A0=C2=A0 select SIMPLEFS
>=20
>=20
> It's not clear to me the Kconfig updated is needed for the ocxl driver.=
=20
> I think it's only needed for the cxl driver.

I am going to get rid of the separate simplefs.c file and related=20
Kconfig entry and put everything in fs/libfs.c, so this file (together=20
with many others touched in this patch) won't be modified in v2.

Thanks,

Emanuele