Re: [PATCH 1/5] parport: add newline to trailing statements
Sudip Mukherjee <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.parport |
|---|---|
| Message-ID | <[email protected]> |
Hi, On Mon, Jul 17, 2017 at 05:36:58PM +0100, Carlos Palminha wrote: > based on checkpatch, add newline to trailing statements > > Signed-off-by: Carlos Palminha <[email protected]> > --- > drivers/parport/daisy.c | 7 +++++-- > drivers/parport/ieee1284.c | 17 +++++++++-------- > drivers/parport/ieee1284_ops.c | 8 ++++++-- > drivers/parport/parport_cs.c | 4 +++- > drivers/parport/parport_gsc.c | 6 ++++-- > drivers/parport/probe.c | 4 +++- > 6 files changed, 30 insertions(+), 16 deletions(-) <snip> > goto try_again; > success: > parport_frob_control (port, PARPORT_CONTROL_STROBE, 0); > diff --git a/drivers/parport/parport_cs.c b/drivers/parport/parport_cs.c > index e9b52e4a4648..993565fef73b 100644 > --- a/drivers/parport/parport_cs.c > +++ b/drivers/parport/parport_cs.c > @@ -88,7 +88,9 @@ static int parport_probe(struct pcmcia_device *link) > > /* Create new parport device */ > info = kzalloc(sizeof(*info), GFP_KERNEL); > - if (!info) return -ENOMEM; > + if (!info) > + return -ENOMEM; Please use tab to indent the code. I know some part of this file uses 4 spaces to indent, so if you use one tab before 'return -ENOMEM', it will look perfect. -- Regards Sudip