Re: [PATCH] Add driver for SUNIX Mutli-I/O board

Hi,

On Thu, Jul 25, 2019 at 12:39 PM Morris Ku <[email protected]> wrote:
>
> hi,Kai-Heng,
> Thanks for review, my replies are inline:
>
> Signed-off-by: Morris Ku <[email protected]>
>
> >at 5:58 PM, morrisku <[email protected]> wrote:
>
> >> This driver support SUNIX multi-io driver.
> >>
> >> Signed-off-by: Morris Ku <[email protected]>
> >> ---
> >>  sunix_pci_multi_io.c | 409 +++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 409 insertions(+)
> >>  create mode 100644 sunix_pci_multi_io.c
> >>
> >> diff --git a/sunix_pci_multi_io.c b/sunix_pci_multi_io.c
>
> >Signed-off-by: Morris Ku <[email protected]>
> >---
> > sunix_pci_multi_io.c | 409 +++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 409 insertions(+)
> > create mode 100644 sunix_pci_multi_io.c
> >Where do I put this driver under? drivers/mfd?
>
> i put the driver under /drivers/parport,
> if you recommend that put driver under /driver/mfd,
> i will send the a new patch.

This should be in parport. Can you please use checkpatch on your patch
and fix the errors. And also while sending the revised patch please
include [email protected] in cc.


-- 
Regards
Sudip