Re: [PATCH] pata_parport: second preview

On 2022/02/21 7:49, Ondrej Zary wrote:
> Hello,
> here's a second version of pata_parport. Now a complete patch with protocol
> drivers (cleaned up coding style).
> 
> The device model is complete now (pata_parport bus, protocol drivers and
> manually created devices). Devices can also be deleted:
> # echo pata_parport.0 > /sys/bus/pata_parport/delete_device 
> 
> Protocol registration could be improved - I don't like protocols[] and
> protocol numbers, devices should probably be created by protocol name.
> Also the LPT port base addresses should probably be replaced by port names
> (like parport0).
> 
> The bpck driver seems to need to know if a CD drive is attached (weird) but
> I doubt that I can get such info from libata.
> 
> I haven't tested other devices yet, only the Imation SuperDisk drive:
> 
> [ 4297.947270] paride: epat registered as protocol 0
> [ 4302.019782] pata_parport pata_parport.0: 0x378 is parport0
> [ 4302.030573] pata_parport pata_parport.0: epat: port 0x378, mode 0, ccr 0, test=(0,256,0)
> [ 4302.030587] pata_parport pata_parport.0: Sharing parport0 at 0x378
> [ 4302.030719] pata_parport pata_parport.0: epat, Shuttle EPAT chip c6 at 0x378, mode 0 (4-bit), delay 0
> [ 4302.062891] scsi host4: pata_parport-epat
> [ 4302.063036] ata6: PATA max PIO0 port parport0 protocol epat
> [ 4302.277720] ata6.00: ATAPI: LS-120 COSM   04              UHD Floppy, 0270M09T, max PIO2
> [ 4302.358986] scsi 4:0:0:0: Direct-Access     MATSHITA LS-120 COSM   04 0270 PQ: 0 ANSI: 5
> [ 4302.394406] sd 4:0:0:0: Attached scsi generic sg1 type 0
> [ 4302.429152] sd 4:0:0:0: [sdb] Media removed, stopped polling
> [ 4302.461007] sd 4:0:0:0: [sdb] Attached SCSI removable disk
> 
> 
> ---
>  drivers/ata/Kconfig                     |  25 +
>  drivers/ata/Makefile                    |   2 +
>  drivers/ata/pata_parport/Kconfig        | 189 ++++++
>  drivers/ata/pata_parport/Makefile       |  24 +
>  drivers/ata/pata_parport/aten.c         | 139 +++++
>  drivers/ata/pata_parport/bpck.c         | 481 +++++++++++++++
>  drivers/ata/pata_parport/bpck6.c        | 164 +++++
>  drivers/ata/pata_parport/comm.c         | 198 ++++++
>  drivers/ata/pata_parport/dstr.c         | 226 +++++++
>  drivers/ata/pata_parport/epat.c         | 320 ++++++++++
>  drivers/ata/pata_parport/epia.c         | 308 ++++++++++
>  drivers/ata/pata_parport/fit2.c         | 135 +++++
>  drivers/ata/pata_parport/fit3.c         | 195 ++++++
>  drivers/ata/pata_parport/friq.c         | 263 ++++++++
>  drivers/ata/pata_parport/frpw.c         | 292 +++++++++
>  drivers/ata/pata_parport/kbic.c         | 292 +++++++++
>  drivers/ata/pata_parport/ktti.c         | 112 ++++
>  drivers/ata/pata_parport/on20.c         | 136 +++++
>  drivers/ata/pata_parport/on26.c         | 302 +++++++++
>  drivers/ata/pata_parport/pata_parport.c | 773 ++++++++++++++++++++++++
>  drivers/ata/pata_parport/pata_parport.h | 114 ++++

This is a very large patch... Could you split this into multiple patches ?
1) The first patch adds the generic pata_parport & Kconfig
2) Following patches add pata_parport drivers, one patch per driver.

That will make reviewing easier.



-- 
Damien Le Moal
Western Digital Research