Re: [PATCH 1/6] sparc32: Use generic cmpdi2/ucmpdi2 variants
"Maciej W. Rozycki" <[email protected]> Sat, 24 Feb 2024 02:54:28 +0000 (GMT)
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.parport,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 23 Feb 2024, Sam Ravnborg via B4 Relay wrote: > Use the generic variants - the implementation is the same. > As a nice side-effect fix the following warnings: > > cmpdi2.c: warning: no previous prototype for '__cmpdi2' [-Wmissing-prototypes] > ucmpdi2.c: warning: no previous prototype for '__ucmpdi2' [-Wmissing-prototypes] > > Signed-off-by: Sam Ravnborg <[email protected]> > Cc: "David S. Miller" <[email protected]> > Cc: Andreas Larsson <[email protected]> > --- LGTM. You may wish to add: Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally") but otherwise: Reviewed-by: Maciej W. Rozycki <[email protected]> Tested-by: Maciej W. Rozycki <[email protected]> # build-tested Maciej