Re: [PATCH v2 7/7] sparc32: Fix section mismatch in leon_pci_grpci
Andreas Larsson <[email protected]> Thu, 7 Mar 2024 19:20:11 +0100
| Newsgroups | gmane.linux.ports.sparc,gmane.linux.parport,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 2024-03-05 16:06, Andreas Larsson wrote: > On 2024-02-24 18:42, Sam Ravnborg via B4 Relay wrote: >> From: Sam Ravnborg <[email protected]> >> >> Passing a datastructre marked _initconst to platform_driver_register() >> is wrong. Drop the __initconst notation. >> >> This fixes the following warnings: >> >> WARNING: modpost: vmlinux: section mismatch in reference: grpci1_of_driver+0x30 (section: .data) -> grpci1_of_match (section: .init.rodata) >> WARNING: modpost: vmlinux: section mismatch in reference: grpci2_of_driver+0x30 (section: .data) -> grpci2_of_match (section: .init.rodata) >> >> Signed-off-by: Sam Ravnborg <[email protected]> >> Cc: "David S. Miller" <[email protected]> >> Cc: Andreas Larsson <[email protected]> > > Could you also add > > Fixes: 4154bb821f0b ("sparc: leon: grpci1: constify of_device_id") > Fixes: 03949b1cb9f1 ("sparc: leon: grpci2: constify of_device_id") > > for these fixes in your v3 of the series as well as CCing stable? I'll pick up the whole series apart for the ZONE_DMA removal, so there is no other need for a v3. I can add the Fixes lines to this one, if it is ok with you Sam, or take it as is. Thanks, Andreas