Re: [PATCH v2 1/7] sparc32: Use generic cmpdi2/ucmpdi2 variants

Andreas Larsson <[email protected]> Fri, 8 Mar 2024 21:00:45 +0100
Newsgroups gmane.linux.ports.sparc,gmane.linux.parport,gmane.linux.kernel
Message-ID <[email protected]>
On 2024-02-24 18:42, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <[email protected]>
> 
> Use the generic variants - the implementation is the same.
> As a nice side-effect fix the following warnings:
> 
> cmpdi2.c: warning: no previous prototype for '__cmpdi2' [-Wmissing-prototypes]
> ucmpdi2.c: warning: no previous prototype for '__ucmpdi2' [-Wmissing-prototypes]
> 
> Signed-off-by: Sam Ravnborg <[email protected]>
> Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally")
> Reviewed-by: Randy Dunlap <[email protected]>
> Tested-by: Randy Dunlap <[email protected]> # build-tested
> Reviewed-by: Maciej W. Rozycki <[email protected]>
> Tested-by: Maciej W. Rozycki <[email protected]> # build-tested
> Cc: "David S. Miller" <[email protected]>
> Cc: Andreas Larsson <[email protected]>
> ---
>  arch/sparc/Kconfig       |  2 ++
>  arch/sparc/lib/Makefile  |  4 ++--
>  arch/sparc/lib/cmpdi2.c  | 28 ----------------------------
>  arch/sparc/lib/ucmpdi2.c | 20 --------------------
>  4 files changed, 4 insertions(+), 50 deletions(-)

Reviewed-by: Andreas Larsson <[email protected]>
Tested-by: Andreas Larsson <[email protected]>

Picking this up to my for-next.

Thanks,
Andreas