Re: [PATCH v2 6/7] sparc32: Fix parport build with sparc32

"Maciej W. Rozycki" <[email protected]> Sat, 9 Mar 2024 09:06:47 +0000 (GMT)
Newsgroups gmane.linux.ports.sparc,gmane.linux.parport,gmane.linux.kernel,gmane.linux.kernel.stable
Message-ID <[email protected]>
On Fri, 8 Mar 2024, Andreas Larsson wrote:

> > include/asm/parport.h is sparc64 specific.
> > Rename it to parport_64.h and use the generic version for sparc32.
> > 
> > This fixed all{mod,yes}config build errors like:
> > 
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_enable
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_irq_enable
> > parport_pc.c:(.text):undefined-reference-to-ebus_dma_register
> > 
> > The errors occur as the sparc32 build references sparc64 symbols.
> > 
> > Signed-off-by: Sam Ravnborg <[email protected]>
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Andreas Larsson <[email protected]>
> > Cc: Randy Dunlap <[email protected]>
> > Cc: Maciej W. Rozycki <[email protected]>
> > Closes: https://lore.kernel.org/r/[email protected]/
> > Fixes: 66bcd06099bb ("parport_pc: Also enable driver for PCI systems")
> > Cc: [email protected] # v5.18+
> > ---
> >  arch/sparc/include/asm/parport.h    | 259 +-----------------------------------
> >  arch/sparc/include/asm/parport_64.h | 256 +++++++++++++++++++++++++++++++++++
> >  2 files changed, 263 insertions(+), 252 deletions(-)
> 
> Reviewed-by: Andreas Larsson <[email protected]>

Reviewed-by: Maciej W. Rozycki <[email protected]>
Tested-by: Maciej W. Rozycki <[email protected]> # build-tested

  Maciej