Re: shadow-4.0.11 breaks shadow group support

On Tue, 19 Jul 2005, Greg Schafer wrote:

> Hi
>
> This latest release breaks shadow group suport. For example, trying to run
> grpconv results in:
[..]
> In summary, it appears shadow group support is very broken and the
> autoconfigury is confused. I'm not sure of the best way to fix it.

Seems some bugs in autoconf was unhided by some cleanups because result 
--{dis,en}able-foo is avalaible only inside AC_ARG_ENABLE(). All previouse 
verions it was looking like working only because noone was try to disable
shadow group support :>
I'm just working on this. My current fix for this is:

--- configure.in        19 Jul 2005 09:52:29 -0000      1.111
+++ configure.in        19 Jul 2005 12:35:52 -0000
@@ -201,7 +201,15 @@
  AC_DEFINE(getpass, libshadow_getpass,
         [Define to libshadow_getpass to use our own version of getpass().])

-AC_ARG_ENABLE(shadowgrp, [  --enable-shadowgrp      enable shadow group support [default=yes]])
+AC_ARG_ENABLE(shadowgrp,
+       [  --enable-shadowgrp         enable shadow group support [default=yes]],
+       [case "${enableval}" in
+        yes) enable_shadowgrp="yes" ;;
+         no) enable_shadowgrp="no" ;;
+          *) AC_MSG_ERROR(bad value ${enableval} for --enable-shadowgrp) ;;
+        esac],
+       [enable_shadowgrp="no"]
+)

  AC_ARG_WITH(libcrack, [  --with-libcrack       try to use libcrack (default if found)])
  AC_ARG_WITH(libpam,   [  --with-libpam                 use libpam for PAM support])


but I want add reporting on finish configure enable/disable some major 
shadow feactures for better cach this kind bugs.

Seems next version will be in day or two :> (probaby 4.0.11.1 if nothing 
more bad will happen).

Thank you for cache this bug.

kloczek
-- 
-----------------------------------------------------------
*Ludzie nie majÂą problemĂłw, tylko sobie sami je stwarzajÂą*
-----------------------------------------------------------
Tomasz KÂłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*