Re: patch for lastlog

On Thu, 25 Aug 2005 [email protected] wrote:

> Attached is a relatively simple patch against lastlog from shadow-4.0.12 which
> adds, what I believe is a useful new functionality: the ability to show only
> people who have last logged in more than x days ago.
> I came upon this problem when I decided to remove all accounts of users on my
> server who haven't logged in during the past two years, so I wrote this quick
> patch. I hope this becomes useful for anyone in the same situation.
> I'm not sure if --before would be the best name for the parameter, so feel free
> to change it if you can find a better name.

Patch looks good but two things are missing:
- document -b option in man/lastlog.8.xml,
- prevent using -b options with other ortogonal options and exit with
   E_BAD_ARG (defined in lib/exitcodes.h) and some error message if it
   occures.

I'm just finish my work today (I'm going to concert Jean Michalel Jarre in 
Gdansk :) so if you will not finish above to tmorrow I'll try finish this.

Thank You.

kloczek
-- 
-----------------------------------------------------------
*Ludzie nie majÂą problemĂłw, tylko sobie sami je stwarzajÂą*
-----------------------------------------------------------
Tomasz KÂłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*