Re: shadow fails to compile with gcc-2
Tomasz Kłoczko <[email protected]> Sun, 4 Sep 2005 15:33:47 +0200 (CEST)
| Newsgroups | gmane.linux.pld.shadow.general |
|---|---|
| Message-ID | <[email protected]> |
On Sat, 3 Sep 2005, Mike Frysinger wrote: > src/newgrp.c declares some variables in the middle of scope and gcc-2 rejects > this ... the child/pid variables could either be moved up to the top of the > if scope, or the USE_PAM code could be given a local scope ... ive attached a > patch by Martin Schlemmer for the former behavior gcc-3 nad gcc-4 allow use this kind construction without output warings. I understand that you probably use gcc-2 for probably some embeded systems (because gcc 2.x generates in some cases smaller code) but understand also me: I want keep shadow code in best readable form. Current form in this area is IMO better. If you want I can put this patch on shadow ftp site (?) (and any other gcc-2 neccessary patches) kloczek -- ----------------------------------------------------------- *Ludzie nie majÂą problemĂłw, tylko sobie sami je stwarzajÂą* ----------------------------------------------------------- Tomasz KÂłoczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]*