shadow-4.014 todo ? (was: Announce: shadow 4.0.13)
Mike Frysinger <[email protected]> Mon, 10 Oct 2005 18:40:46 -0400
| Newsgroups | gmane.linux.pld.shadow.general |
|---|---|
| Organization | wh0rd.org |
| Message-ID | <[email protected]> |
On Monday 10 October 2005 02:47 pm, Tomasz Kłoczko wrote: > My current (short) TODO list for next version: - running `./configure` on a non-selinux system still aborts http://lists.pld.org.pl/mailman/pipermail/shadow/2005-September/000217.html - fix typo with shadow_cv_logdir vs logdir in configure patch attached - only install localized manpages when configured with --enable-nls patch attached - touchup environ import from user in `su` patch attached - make group length restrictions a configure option ? ./configure --with-max-group-len=[#|none] libmisc/chkname.c will use this setting rather than just always hardcoding a max len of 16 ... -mike
shadow-4.0.10-fix-configure.patch
(text/x-diff, 579 B)
Fix wrong var name --- configure.in +++ configure.in @@ -165,7 +165,7 @@ AC_DEFINE_UNQUOTED(_UTMP_FILE, "$shadow_ AC_CACHE_CHECK([location of faillog/lastlog/wtmp], shadow_cv_logdir, [for shadow_cv_logdir in /var/log /var/adm /usr/adm /etc; do - if test -d $logdir; then + if test -d $shadow_cv_logdir; then break fi done]) --- configure +++ configure @@ -22349,7 +22348,7 @@ echo $ECHO_N "(cached) $ECHO_C" >&6 else for shadow_cv_logdir in /var/log /var/adm /usr/adm /etc; do - if test -d $logdir; then + if test -d $shadow_cv_logdir; then break fi done
shadow-4.0.13-su-fix-environment.patch
(text/x-diff, 1 KB)
The patch from upstream (shadow-4.0.11.1-SUPATH.patch) sets environ too
early when using PAM, so move it to !USE_PAM. Also set USER and SHELL.
--- shadow-4.0.11.1/src/su.c 2005-08-04 12:34:35.000000000 +0200
+++ shadow-4.0.11.1.az/src/su.c 2005-08-04 12:38:57.000000000 +0200
@@ -594,11 +594,6 @@
addenv ("PATH", cp);
}
-#ifndef USE_PAM
- /* setup the environment for PAM later on, else we run into auth problems */
- environ = newenvp; /* make new environment active */
-#endif
-
if (getenv ("IFS")) /* don't export user IFS ... */
addenv ("IFS= \t\n", NULL); /* ... instead, set a safe IFS */
@@ -666,6 +664,8 @@
exit (1);
}
#else /* !USE_PAM */
+ environ = newenvp; /* make new environment active */
+
if (!amroot) /* no limits if su from root */
setup_limits (&pwent);
@@ -676,8 +676,11 @@
if (fakelogin)
setup_env (&pwent);
#if 1 /* Suggested by Joey Hess. XXX - is this right? */
- else
+ else {
addenv ("HOME", pwent.pw_dir);
+ addenv ("USER", pwent.pw_name);
+ addenv ("SHELL", pwent.pw_shell);
+ }
#endif
/*
shadow-4.0.10-nls-manpages.patch
(text/x-diff, 367 B)
Don't install localized manpages is USE=-nls e-mailed upstream already --- man/Makefile.in +++ man/Makefile.in @@ -153,7 +153,11 @@ target_alias = @target_alias@ # subdirectories for translated manual pages +ifeq ($(USE_NLS),no) +SUBDIRS = +else SUBDIRS = cs de es fr hu id it ja ko pl pt_BR ru zh_CN zh_TW +endif man_XMANS = \ chage.1.xml \ chfn.1.xml \