Re: Incorrect behavior for multiple tries of login
Tomasz Kłoczko <[email protected]> Mon, 10 Jul 2006 06:22:50 +0200 (CEST)
| Newsgroups | gmane.linux.pld.shadow.general |
|---|---|
| Message-ID | <[email protected]> |
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1164271625-1152505370=:10018 Content-Type: TEXT/PLAIN; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 9 Jul 2006, Dan Nicholson wrote: > Hi, > > login has slightly incorrect behavior when a user tries to login > repeatedly when using PAM. If the user enters the correct password on > the final attempt when failcount == retries, login fails with the > message "Maximum number of tries exceeded". The problem is that login > doesn't test for PAM_SUCCESS when testing failcount >= retries. > Attached is a patch to fix this problem. > > This was tested against shadow-4.0.15. I haven't tested against 4.0.16 > or CVS HEAD, but looking at the source, it doesn't seem to be > different. Now I have no time for full verify above so I'll look ok this patch after release 4.0.17. > Also, would it be a problem to add the address in the Cc: field to a > whitelist? He brought this issue to my attention and created the > patch. He says that he tried to subscribe to your list but his mail > server is blacklisted. Done. kloczek -- ----------------------------------------------------------- *Ludzie nie maj± problemów, tylko sobie sami je stwarzaj±* ----------------------------------------------------------- Tomasz K³oczko, sys adm @zie.pg.gda.pl|*e-mail: [email protected]* --0-1164271625-1152505370=:10018 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline