Re: shadow 4.0.18.1: useradd -g broken (patch incl.)

Hi Tomasz,

any reason you hesitate applying this patch from Debian?


On Tue, 19 Sep 2006 06:34:47 +0200
Christian Perrier <[email protected]> wrote:

> forwarded 381394 [email protected]
> thanks
> 
> Quoting Brandon Peirce ([email protected]):
> > I wrote:
> > >Hello,
> > >
> > >The fix from
> > >http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198920 seems
> > >to have completely broken the -g option of useradd.
> > >(src/usradd.c  $Id: 1.100)
> > 
> > The indents in the patch got lost in the cut & paste - sorry :(
> > Patch resent as attachment.
> 
> 
> For the sake of it, here's the patch we use in Debian for that problem
> (bugs #381394, #381399, #381404, #381408, #381448 in Debian BTS).
> 
> It seems, by the way, that, contrary to our usual policy, we did not
> send it to Tomasz. We use to send our patches directly to him. Maybe
> we should indeed send them to this list (which I, as one of shadow
> maintainers in Debian, am subscribed to) so that they're exposed to
> peer review, especially by maintainers of shadow in other distros.
> 
> I'm not in the position of comparing both patches indeed but I guess
> that Tomasz will (though we haven't heard from him in the last weeks).
> 
>