Re: chpasswd stack overflow

On Wed, 8 Nov 2006 14:27:16 +0100
Peter Vrabec <[email protected]> wrote:

any comments?

> 
> proposed patch
> 
> 
> On Tue, 7 Nov 2006 14:55:06 +0100
> Peter Vrabec <[email protected]> wrote:
> 
> > Hi Tomasz,
> > 
> > 
> > the strcat is overflowing salt in chpasswd.c and chgpasswd.c:
> > ....
> >  if (!eflg) {
> >                         if (md5flg) {
> >                                 char salt[12] = "$1$";
> > 
> >                                 strcat (salt, crypt_make_salt ());
> >                                 cp = pw_encrypt (newpwd, salt);
> >                         } else
> >                                 cp = pw_encrypt (newpwd,
> > 				crypt_make_salt ());
> >                 }
> > .....
> > 
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=213052
> > _______________________________________________
> > shadow mailing list
> > [email protected]
> > http://mail.pld.org.pl/mailman/listinfo/shadow