Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros
Krzysztof Wilczyński <[email protected]>
| Newsgroups | gmane.linux.ports.alpha,gmane.linux.kernel.pci,gmane.linux.ports.ppc64.devel |
|---|---|
| Message-ID | <20260410112709.GB1756033@rocinante> |
Hello,
> > - if (pdev->resource[num].flags & IORESOURCE_MEM) {
> > + if (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {
>
> Reviewed-by: Ilpo Järvinen <[email protected]>
>
> I started wonder though if we'd want to add pci_resource_is_mem/io()
> shortcuts for these, as it's largely what
>
> git grep pci_resource_flags
>
> results contain.
I see what you mean... We can introduce such helpers here, and be the first
users within the PCI tree, that is, before someone will do a tree-wide or some
more granular update eventually.
Should I do it? Thoughts?
Thank you!
Krzysztof