Re: [RFC V2 6/6] mm: Drop pxd_ERROR()
Geert Uytterhoeven <[email protected]>
| Newsgroups | gmane.linux.ports.ppc64.devel,gmane.linux.kernel.mm,gmane.linux.ports.alpha,gmane.linux.kernel.arc,gmane.linux.ports.arm.kernel,gmane.linux.ports.hexagon,gmane.linux.ports.mips,gmane.linux.ports.parisc,gmane.linux.ports.riscv,gmane.linux.ports.sh.devel,gmane.linux.ports.sparc,gmane.linux.uml.devel,gmane.linux.kernel.cross-arch,gmane.linux.kernel |
|---|---|
| Message-ID | <CAMuHMdXfpkpYzZWGVb0fQrdn3uYHU3pyCkyAX9o2ux_Jj=2ByA@mail.gmail.com> |
Hi Anshuman, Thanks for your patch! On Tue, 11 Aug 2026 at 06:22, Anshuman Khandual <[email protected]> wrote: > pxd_ERROR() has been used in generic mm just to print the page table entry > in pxd_clear_bad() before clearing those out with pxd_clear() later. These > pxd_ERROR() macros have been provided by all platforms which basically did > the same thing. > > Make pxd_clear_bad() use recently added ptval_to_str() instead for printing > page table entries thus completely dropping dependency on platform provided > pxd_ERROR() macros which can then be dropped off. First move all required > helpers in core MM into a header file which could then be used else where. Oh, the "x" in "pxd" is a wildcard? Except that is not, as it does not match "pte" ;-) > Signed-off-by: Anshuman Khandual <[email protected]> > arch/m68k/include/asm/mcf_pgtable.h | 6 --- > arch/m68k/include/asm/motorola_pgtable.h | 8 ---- > arch/m68k/include/asm/sun3_pgtable.h | 7 ---- Acked-by: Geert Uytterhoeven <[email protected]> # m68k Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds