Re: Patch for kernel 2.6.29 STR9104NAS
Russell King - ARM Linux <[email protected]>
| Newsgroups | gmane.linux.ports.arm.general |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Mar 30, 2009 at 07:22:12PM +0700, Yohanes Nugroho wrote: > On Sun, Mar 29, 2009 at 1:06 PM, Yohanes Nugroho <[email protected]> wrote: > > Anyone care to test/review my patch? > > I realized that the patch is good for testing (one patch that can be > applied quickly), but not good for reviewing, I will split this patch > into several patches: > > - patch for supporting FA526 CPU > - patch for STR9104 SoC (but this is still to big, the header files > from starsemi is very big, i think I will need to remove unnecessary > things) > - one patch for each driver (USB, Network, LED) > > Will that be good enough? should i split smaller? (a) you should be sending this to linux-arm-KERNEL not linux-arm. (b) we now have FA526 support in mainline (see the 2.6.29-git snapshots), so you may want to check whether this can be used with your SoC. (c) splitting the patch up as you've detailed above and posting the _contents_ of each to the list (and any other relevent list) would be a good thing. Eg, USB stuff doesn't get reviewed on any of the linux-arm* lists. ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php