Re: [PATCH] regulator: qcom_spmi: Add slewing delays for all SMPS types

Mark Brown <[email protected]> Tue, 29 Mar 2016 16:09:31 -0700

Newsgroups	gmane.linux.ports.arm.general
Message-ID	<20160329230931.GT2350__35173.9441081465$1459293423$gmane$org@sirena.org.uk>

On Tue, Mar 29, 2016 at 03:58:40PM -0700, Stephen Boyd wrote:

> -	if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS) {
> -		ret = spmi_regulator_ftsmps_init_slew_rate(vreg);
> +	if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_LO_SMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_ULT_HO_SMPS ||
> +	    vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_SMPS) {
> +		ret = spmi_regulator_init_slew_rate(vreg);

This should be a switch statement.  Otherwise this looks fine.

_______________________________________________
linux-arm mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm

signature.asc (application/pgp-signature, 473 B)