Re: [PATCH] regulator: qcom_spmi: Add support for pmi8994

Stephen Boyd <[email protected]> Thu, 2 Nov 2017 10:58:16 -0700
Newsgroups gmane.linux.ports.arm.general
Message-ID <a5381e40-7ee4-6942-e38d-c18e2e8d8e26__5333.6237361238$1509645523$gmane$org@codeaurora.org>
On 11/02/2017 02:24 AM, Rajendra Nayak wrote:
> Document the regulators available on pmi8994 and add support for
> this PMIC to the SPMI PMIC regulator driver.
>
> Signed-off-by: Rajendra Nayak <[email protected]>

Reviewed-by: Stephen Boyd <[email protected]>
Tested-by: Stephen Boyd <[email protected]>

> diff --git a/drivers/regulator/qcom_spmi-regulator.c b/drivers/regulator/qcom_spmi-regulator.c
> index 16c5f84..9f8eb5d 100644
> --- a/drivers/regulator/qcom_spmi-regulator.c
> +++ b/drivers/regulator/qcom_spmi-regulator.c
> @@ -1619,11 +1619,20 @@ static int spmi_regulator_of_parse(struct device_node *node,
>  	{ }
>  };
>  
> +static const struct spmi_regulator_data pmi8994_regulators[] = {
> +	{ "s1", 0x1400, "vdd_s1", },
> +	{ "s2", 0x1700, "vdd_s2", },
> +	{ "s3", 0x1a00, "vdd_s3", },
> +	{ "l1", 0x4000, "vdd_l1", },
> +        { }

Should be a tab instead of spaces?

> +};

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project