[PATCH v9 03/22] drm/bridge: synopsys: dw-dp: Fix error handling in dw_dp_link_enable()
Sebastian Reichel <sebastian.reichel-ZGY8ohtN/[email protected]>
| Newsgroups | gmane.linux.drivers.devicetree,gmane.comp.video.dri.devel,gmane.linux.ports.arm.rockchip,gmane.linux.kernel,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <20260803-synopsys-dw-dp-improvements-v9-3-2e6e46135312@collabora.com> |
Add missing error handling in dw_dp_link_enable(), which failed to
release resources it already requested before hitting an error.
Fixes: 86eecc3a9c2e ("drm/bridge: synopsys: Add DW DPTX Controller support library")
Reported-by: Sashiko <[email protected]>
Signed-off-by: Sebastian Reichel <sebastian.reichel-ZGY8ohtN/[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-dp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 06997208945e..e332d66b8057 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1636,10 +1636,19 @@ static int dw_dp_link_enable(struct dw_dp *dp)
ret = drm_dp_link_power_up(&dp->aux, dp->link.revision);
if (ret < 0)
- return ret;
+ goto err_phy_power_off;
ret = dw_dp_link_train(dp);
+ if (ret < 0)
+ goto err_link_power_down;
+
+ return 0;
+
+err_link_power_down:
+ drm_dp_link_power_down(&dp->aux, dp->link.revision);
+err_phy_power_off:
+ phy_power_off(dp->phy);
return ret;
}
--
2.53.0