Re: [PATCH v7 12/23] firmware: arm_scmi: Add support for boot-on Telemetry

Fayssal Benmlih <[email protected]>
Newsgroups gmane.linux.documentation,gmane.linux.ports.arm.kernel,gmane.linux.kernel
Message-ID <[email protected]>
Hi Cristian,

One error-handling issue inline.

> 	for (int i = 0; i < ti->info.base.num_groups; i++)
> 		scmi_telemetry_group_config_lookup(ti,
> 						   &rinfo->grps[i]);
>
> 	rinfo->num_groups = ti->info.base.num_groups;
>
> 	return 0;

The return value from every group configuration lookup is discarded.

If firmware rejects one lookup or returns a transport error, that group is
still exposed with zero/default cached state, rinfo->num_groups includes
it, and enumeration is reported as successful.

Please propagate the first error, or explicitly mark individual group
state as unavailable while preserving the partial-enumeration status.

Thanks,
Fayçal
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.