Re: [PATCH v7 00/23] Introduce SCMI Telemetry support

Hi Cristian,

Thanks for posting V7.

As you are already aware per your plans for V8, the ioctl interface is not
ready to be accepted for upstream yet. There are still several UAPI 
correctness, validation, concurrency, and lifetime issues that should
be resolved before this ABI is exposed to userspace and becomes
difficult to change.

In particular, the batch ioctl encoding does not match the structure
actually copied by the driver, user-controlled allocation and mmap
parameters are not sufficiently bounded, several configuration
operations can leave partially updated state, and the lifetime of open
file descriptors and mappings does not appear to be tied safely to the
underlying SCMI objects. Event subscriptions also need per-open
ownership and cleanup.

I have provided the individual details as inline comments on the
relevant patches. Please address those issues, update the documentation
and test tool to match the final ABI, and post another revision for review
in V8.

Thanks,
Fayçal