[PATCH v4 2/7] dt-bindings: media: i2c: Utilise video-interface-devices enums
Kieran Bingham <[email protected]> Tue, 04 Aug 2026 20:43:29 +0100
| Newsgroups | gmane.linux.kernel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.msm,gmane.linux.kernel.renesas-soc,gmane.linux.ports.arm.rockchip,gmane.linux.ports.tegra |
|---|---|
| Message-ID | <[email protected]> |
The orientation property for video interface devices now has definitions to prevent hardcoded integer values for the enum options. Update the existing examples throughout the bindings documentation for camera sensors. Reviewed-by: Vladimir Zapolskiy <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Benjamin Mugnier <[email protected]> Reviewed-by: David Heidelberg <[email protected]> Signed-off-by: Kieran Bingham <[email protected]> --- Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/ovti,ov64a40.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml | 3 ++- Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml | 3 ++- 12 files changed, 24 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml index 1a57f2aa198228dff784aad25c2c0e39b6c32a9a..b7bc6ba26e6ea37e75b17d02b73d68e7b6772d2d 100644 --- a/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml +++ b/Documentation/devicetree/bindings/media/i2c/hynix,hi846.yaml @@ -86,6 +86,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -102,7 +103,7 @@ examples: vddio-supply = <®_camera_vddio>; reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; shutdown-gpios = <&gpio5 4 GPIO_ACTIVE_LOW>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; rotation = <0>; port { diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml index 6f2017c7512566d47fc04fbd4c672cb9633ca990..b9c61395b24faf8d4938d4bcd218fc27e385c386 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov08d10.yaml @@ -69,6 +69,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/media/video-interfaces.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -84,7 +85,7 @@ examples: avdd-supply = <&ov08d10_vdda_2v8>; dvdd-supply = <&ov08d10_vddd_1v2>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; rotation = <0>; reset-gpios = <&gpio 1 GPIO_ACTIVE_LOW>; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml index d96199031b66c5c162a034824f195e277f2a1795..fcd617848ce316f40d084f55686c636c6a0e7c51 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml @@ -96,6 +96,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -114,7 +115,7 @@ examples: powerdown-gpios = <&pio 107 GPIO_ACTIVE_LOW>; reset-gpios = <&pio 109 GPIO_ACTIVE_LOW>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; rotation = <0>; port { diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml index ad07204057f979ade534d29c99c3aff7372bd332..6df62fd0c0c0dd84928261f375b3d45cd7323b04 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5675.yaml @@ -85,6 +85,7 @@ examples: - | #include <dt-bindings/clock/px30-cru.h> #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> i2c { @@ -108,7 +109,7 @@ examples: dovdd-supply = <&vcc_2v8>; rotation = <90>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; port { ucam_out: endpoint { diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml index 3368b3bd8ef2f0b648b239a8ec7d948d4d795bd6..5732657e1484eae4e0ae33e2df976db150c87ad0 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml @@ -103,6 +103,7 @@ examples: - | #include <dt-bindings/clock/px30-cru.h> #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> i2c { @@ -126,7 +127,7 @@ examples: dovdd-supply = <&vcc_2v8>; rotation = <90>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; port { ucam_out: endpoint { diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov64a40.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov64a40.yaml index 2b6143aff39139c6cb1f6dc514cddd6dd5d3a0cf..24787c9aa1557bdabe7ce86df3346e80d3dd7221 100644 --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov64a40.yaml +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov64a40.yaml @@ -72,6 +72,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -87,7 +88,7 @@ examples: powerdown-gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>; reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; rotation = <180>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; port { endpoint { diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml index 20f48d5e9b2d8cc32712f697629ded2452c83e62..56fb5f18f07bf7af04bcec32f68721c7b04b35a2 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml @@ -69,6 +69,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/media/video-interfaces.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -84,7 +85,7 @@ examples: dvdd-supply = <&camera_vddd_1v2>; avdd-supply = <&camera_vdda_2v7>; - orientation = <1>; + orientation = <MEDIA_ORIENTATION_BACK>; rotation = <90>; nvmem = <&eeprom>; diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml index d9cdfda699bfeea68767b5ed36be7a0280348ec8..6699c238ee0e6c54c01b5fe0401478b5c620f418 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx355.yaml @@ -81,6 +81,7 @@ examples: - | #include <dt-bindings/clock/qcom,camcc-sdm845.h> #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -105,7 +106,7 @@ examples: pinctrl-0 = <&cam_front_default>; rotation = <270>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; port { cam_front_endpoint: endpoint { diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml index 7c11e871dca67b2c1d1bcc40344f684fb47a3d06..69a37ff68db3be6b30642b149bcbf7a47629b0b5 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml @@ -86,6 +86,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -98,7 +99,7 @@ examples: clocks = <&clock_cam>; dvdd-supply = <&vcc1v1_cam>; lens-focus = <&vcm>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; ovdd-supply = <&vcc1v8_cam>; reset-gpios = <&gpio_expander 14 GPIO_ACTIVE_LOW>; rotation = <180>; diff --git a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml b/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml index 58b1f9e85a9d1c137b770b0795c88ccc56c62a0a..dfd87beba065c587a4ff1ab249badd10e459f0e5 100644 --- a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml +++ b/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml @@ -106,6 +106,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -124,7 +125,7 @@ examples: reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; st,leds = <2>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; rotation = <0>; port { diff --git a/Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml b/Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml index c6673b8539dbcf16d035025e676f7f7250a5643a..48db22ca4a7e641198bf3ed7f5a991322dd90e75 100644 --- a/Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml +++ b/Documentation/devicetree/bindings/media/i2c/st,vd56g3.yaml @@ -107,6 +107,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -125,7 +126,7 @@ examples: reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; st,leds = <6>; - orientation = <2>; + orientation = <MEDIA_ORIENTATION_EXTERNAL>; rotation = <0>; port { diff --git a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml index bc339a7374b224b9340d2dd3392f9a373f594876..4a66cb71137209298bfd088c51e2ceac3c9d3133 100644 --- a/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml +++ b/Documentation/devicetree/bindings/media/i2c/thine,thp7312.yaml @@ -173,6 +173,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/media/video-interfaces.h> + #include <dt-bindings/media/video-interface-devices.h> i2c { #address-cells = <1>; @@ -196,7 +197,7 @@ examples: vddgpio-0-supply = <&vsys_v4p2>; vddgpio-1-supply = <&vsys_v4p2>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; rotation = <0>; sensors { -- 2.53.0