[PATCH v4 6/7] arm64: dts: rockchip: Convert to new media orientation definitions
Kieran Bingham <[email protected]> Tue, 04 Aug 2026 20:43:33 +0100
| Newsgroups | gmane.linux.kernel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.msm,gmane.linux.kernel.renesas-soc,gmane.linux.ports.arm.rockchip,gmane.linux.ports.tegra |
|---|---|
| Message-ID | <[email protected]> |
The orientation property for video interface devices now has definitions to prevent hardcoded integer values for the enum options. Update the users throughout the rockchip device trees to use the new definitions. Reviewed-by: Laurent Pinchart <[email protected]> Reviewed-by: Quentin Schulz <[email protected]> # PP-1516 and Reviewed-by: David Heidelberg <[email protected]> Signed-off-by: Kieran Bingham <[email protected]> --- arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi | 3 ++- arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dtso | 3 ++- arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 5 +++-- .../boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso | 3 ++- .../boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso | 3 ++- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi b/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi index 192791993f05911326bd8ae451daaa29ccc9ea73..d58d6ee6241e559fddef98510b32f32edc75a310 100644 --- a/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30-pp1516.dtsi @@ -6,6 +6,7 @@ /dts-v1/; #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> #include "px30.dtsi" @@ -413,7 +414,7 @@ camera@36 { dvdd-supply = <&vcc_cam_dvdd>; dovdd-supply = <&vcc_cam_dovdd>; lens-focus = <&focus>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; pinctrl-names = "default"; pinctrl-0 = <&cif_clkout_m0 &cam_pwdn>; reset-gpios = <&gpio2 RK_PB0 GPIO_ACTIVE_LOW>; diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dtso b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dtso index 760d5139f95dfa4f71a2a03bfa140b7a71e40025..2168db9168a590207f3a00e1fbbcae29731dfb96 100644 --- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dtso +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou-video-demo.dtso @@ -16,6 +16,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/irq.h> #include <dt-bindings/leds/common.h> +#include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> &{/} { @@ -185,7 +186,7 @@ camera@36 { dvdd-supply = <&cam_dvdd_1v2>; dovdd-supply = <&cam_dovdd_1v8>; lens-focus = <&focus>; - orientation = <0>; + orientation = <MEDIA_ORIENTATION_FRONT>; pinctrl-names = "default"; pinctrl-0 = <&cif_clkout_m0>; reset-gpios = <&pca9670 6 GPIO_ACTIVE_LOW>; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 8d26bd9b75003cfa8ff7e4921f1c94866db95d39..6608c777f18588b9386a57d936e77783b5d9b4fb 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -13,6 +13,7 @@ #include <dt-bindings/input/gpio-keys.h> #include <dt-bindings/input/linux-event-codes.h> #include <dt-bindings/leds/common.h> +#include <dt-bindings/media/video-interface-devices.h> #include "rk3399-s.dtsi" / { @@ -455,7 +456,7 @@ wcam: camera@1a { reg = <0x1a>; clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */ lens-focus = <&wcam_lens>; - orientation = <1>; /* V4L2_CAMERA_ORIENTATION_BACK */ + orientation = <MEDIA_ORIENTATION_BACK>; pinctrl-names = "default"; pinctrl-0 = <&camera_rst_l>; reset-gpios = <&gpio1 RK_PA0 GPIO_ACTIVE_LOW>; @@ -487,7 +488,7 @@ ucam: camera@36 { clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK1, derived from CIF_CLK0 */ clock-names = "xvclk"; dovdd-supply = <&vcc1v8_dvp>; - orientation = <0>; /* V4L2_CAMERA_ORIENTATION_FRONT */ + orientation = <MEDIA_ORIENTATION_FRONT>; pinctrl-names = "default"; pinctrl-0 = <&camera2_rst_l &dvp_pdn0_h>; powerdown-gpios = <&gpio2 RK_PB4 GPIO_ACTIVE_LOW>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso index ee9ecf68a88663a04e1c33a718894490ef475203..8c9a4a1181e467b457ee37647753c874523117ad 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam0.dtso @@ -9,6 +9,7 @@ #include <dt-bindings/clock/rockchip,rk3588-cru.h> #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> &{/} { @@ -50,7 +51,7 @@ imx415: camera-sensor@1a { avdd-supply = <&savdd_cam0>; clocks = <&cru CLK_MIPI_CAMARAOUT_M3>; dvdd-supply = <&sdvdd_cam0>; - orientation = <2>; /* External */ + orientation = <MEDIA_ORIENTATION_EXTERNAL>; ovdd-supply = <&siovdd_cam0>; pinctrl-names = "default"; pinctrl-0 = <&cam0_rstn &mipim0_camera3_clk>; diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso index 8a4cf3fdbf8ebde8b2939c6126d169074431588a..0cc3d6a34cef36883b6599d4df12a2c5a6aacbc8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b-plus-radxa-cam4k-cam1.dtso @@ -9,6 +9,7 @@ #include <dt-bindings/clock/rockchip,rk3588-cru.h> #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/media/video-interface-devices.h> #include <dt-bindings/pinctrl/rockchip.h> &{/} { @@ -50,7 +51,7 @@ cam1_imx415: camera-sensor@1a { avdd-supply = <&savdd_cam1>; clocks = <&cru CLK_MIPI_CAMARAOUT_M4>; dvdd-supply = <&sdvdd_cam1>; - orientation = <2>; /* External */ + orientation = <MEDIA_ORIENTATION_EXTERNAL>; ovdd-supply = <&siovdd_cam1>; pinctrl-names = "default"; pinctrl-0 = <&cam1_rstn &mipim0_camera4_clk>; -- 2.53.0