Re: [PATCH v3 2/2] arm64: dts: broadcom: bcm2712-d-rpi-5-b: add compatible

On Tue, Aug 04, 2026 at 04:57:09PM +0200, Stefan Wahren wrote:
> Hi Gregor,
> 
> sorry for my late reply.
> 
> Am 04.08.26 um 15:13 schrieb Gregor Herburger:
> > The bcm2712 found on the Raspberry Pi 5 is available in the d Stepping
> > and in a c Stepping. There are two separate dts files. The
> > bcm2712-rpi-5-b.dts for the c Stepping and the bcm2712-d-rpi-5-b.dts for
> > the d Stepping. The d stepping does not set its own compatible/model
> > string but uses "raspberrypi,5-model-b".
> In case the SoC and not the board has a D stepping, why do just change the
> board compatible without the SoC compatible like "brcm,bcm2712-d0"?
> > 
You mean changing both compatible strings? Like this:
	compatible = "raspberrypi,5-model-b-d0", "brcm,bcm2712-d0";

Don't know actually. Have not found an example for something like this in the
tree. I prefer it actually like it is. Would like to hear the opinion of an
devicetree maintainer about this.

> > These two steppings are not compatible. Booting with the wrong dtb file
> > causes a crash at boot.
> This sounds like the patch should have a fixes tag?
Yes can add one.
> > 
> > Add a compatibles string "raspberrypi,5-model-b-d0" to allow us to
> > distinguish between those two steppings.
> > 
> > Signed-off-by: Gregor Herburger <[email protected]>
> > ---
> >   arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> > index 127be0fc27c22..5a86ad69645c3 100644
> > --- a/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-d-rpi-5-b.dts
> > @@ -3,6 +3,11 @@
> >   #include "bcm2712-rpi-5-b.dts"
> > +/ {
> > +	compatible = "raspberrypi,5-model-b-d0", "brcm,bcm2712";
> > +	model = "Raspberry Pi 5 d0 Stepping";
> > +};
> > +
> >   &gio_aon {
> >   	brcm,gpio-bank-widths = <15 6>;
> > 
> 

-- 
Gregor Herburger
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 35; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/legal/data-protection.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Dr. Wilfried Wessner, 
Katharina Kopp, Alexander Gieringer