Re: [PATCH v2 2/3] usb: typec: tipd: Factor out i2c specifics

Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/[email protected]> Wed, 5 Aug 2026 14:40:58 +0200
Newsgroups gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.usb.general,gmane.linux.kernel
Message-ID <[email protected]>
On Wed, Aug 05, 2026 at 01:57:18PM +0200, Sasha Finkelstein wrote:
> On Aug 5, 2026, at 13:47, Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/[email protected]> wrote:
> >> 
> >> -static const struct regmap_config tps6598x_regmap_config = {
> >> +const struct regmap_config tps6598x_regmap_config = {
> >> .reg_bits = 8,
> >> .val_bits = 8,
> >> .max_register = 0x7F,
> >> };
> >> +EXPORT_SYMBOL_GPL(tps6598x_regmap_config);
> > 
> > Don't export that. Just move it to i2c.c
> 
> I use this one in spmi.c too, the regmap configuration is the same,
> just the backend is different

Ah, sorry I missed that.

Thanks,

-- 
heikki