Re: [PATCH v2 3/4] arm64: dts: ti: k3-am62a: Set MMC clock pins as OUTPUT
"Mendez, Judith" <[email protected]> Wed, 5 Aug 2026 09:21:16 -0500
| Newsgroups | gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi all, On 8/5/2026 5:56 AM, Moteen Shah wrote: > Hey Judith, > > On 05/08/26 06:18, Judith Mendez wrote: >> MMC clock pins must be configured as OUTPUT-only per TRM [0] with >> receiver disabled (RXACTIVE bit = 0). Change MMC CLK pins from >> PIN_INPUT to PIN_OUTPUT to match documentation. > > I think this patch and the next one should carry a fixes tag. Yea actually I did not send this series 100% correct, so I was going to send an comment to ignore this version. I will add your review tag for the next version though. Thanks! > > With that for the whole series, > Reviewed-by: Moteen Shah <[email protected]> > > Regards, > Moteen >> [0] https://www.ti.com/lit/pdf/spruj16 Rev. C: Table 12-257. MMCSDi I/ >> O Signals >> >> Signed-off-by: Judith Mendez <[email protected]> >> --- >> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts b/arch/arm64/ >> boot/dts/ti/k3-am62a7-sk.dts >> index b04636cab71c7..e63c5200a2370 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> +++ b/arch/arm64/boot/dts/ti/k3-am62a7-sk.dts >> @@ -328,7 +328,7 @@ AM62AX_IOPAD(0x0b4, PIN_INPUT_PULLUP, 1) /* (K24) >> GPMC0_CSn3.I2C2_SDA */ >> main_mmc0_pins_default: main-mmc0-default-pins { >> pinctrl-single,pins = < >> AM62AX_IOPAD(0x220, PIN_INPUT, 0) /* (Y3) MMC0_CMD */ >> - AM62AX_IOPAD(0x218, PIN_INPUT, 0) /* (AB1) MMC0_CLK */ >> + AM62AX_IOPAD(0x218, PIN_OUTPUT, 0) /* (AB1) MMC0_CLK */ >> AM62AX_IOPAD(0x214, PIN_INPUT, 0) /* (AA2) MMC0_DAT0 */ >> AM62AX_IOPAD(0x210, PIN_INPUT_PULLUP, 0) /* (AA1) >> MMC0_DAT1 */ >> AM62AX_IOPAD(0x20c, PIN_INPUT_PULLUP, 0) /* (AA3) >> MMC0_DAT2 */ >> @@ -344,7 +344,7 @@ AM62AX_IOPAD(0x1f8, PIN_INPUT_PULLUP, 0) /* (AC2) >> MMC0_DAT7 */ >> main_mmc1_pins_default: main-mmc1-default-pins { >> pinctrl-single,pins = < >> AM62AX_IOPAD(0x23c, PIN_INPUT, 0) /* (A21) MMC1_CMD */ >> - AM62AX_IOPAD(0x234, PIN_INPUT, 0) /* (B22) MMC1_CLK */ >> + AM62AX_IOPAD(0x234, PIN_OUTPUT, 0) /* (B22) MMC1_CLK */ >> AM62AX_IOPAD(0x230, PIN_INPUT, 0) /* (A22) MMC1_DAT0 */ >> AM62AX_IOPAD(0x22c, PIN_INPUT, 0) /* (B21) MMC1_DAT1 */ >> AM62AX_IOPAD(0x228, PIN_INPUT, 0) /* (C21) MMC1_DAT2 */