Re: [PATCH v3 01/11] tracing: Include linux/types.h in trace_remote_event.h

On Thu, Aug 06, 2026 at 08:19:52AM -0400, Steven Rostedt wrote:
> On Thu, 6 Aug 2026 09:43:00 +0100
> Fuad Tabba <[email protected]> wrote:
> 
> > > My ack still stands, but I wonder if we should just not use the include and
> > > instead s/bool/_Bool/ ?  
> > 
> > I'd prefer to keep the include, if you don't mind.
> > 
> > As far as I can tell, apart from the typedef itself, the only headers
> > built into the kernel that use _Bool as a type are a uapi one and
> > arch/um's user.h when it's built for the host, neither of which has
> > bool available, plus what looks like a leftover in bcache_ondisk.h
> > from when it was uapi.
> > 
> > The include also covers whatever field gets added next.
> > 
> > Happy to switch if you'd still prefer _Bool.
> 
> The reason I suggested this is because I'm not sure how much we want to add
> Linux headers to files built for the hypervisor.
> 
> If Vincent is good with adding this, then so am I.
> 
> But I rather have him give an ack before we do.
> 
> -- Steve

We have types.h already in several places in the hypervisor, so I think it's
alright to include it here also.

Reviewed-by: Vincent Donnefort <[email protected]>

-- 
Vincent