Re: [PATCH v2 1/4] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-direction phys
Bryan O'Donoghue <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.ports.arm.rockchip |
|---|---|
| Message-ID | <[email protected]> |
On 26/07/2026 15:55, Jason Yang via B4 Relay wrote: > From: Jason Yang <[email protected]> > > The Samsung MIPI D-/C-PHY block on RK3588 drives a MIPI DSI transmitter > and, on the same PHY, can receive a MIPI CSI camera. Describing both as > independent consumers of one PHY requires the direction to be expressed > in the devicetree. > > Allow "#phy-cells" to be 1 or 2. The existing single-cell form still > selects the PHY type and refers to the transmitter, so shipped DSI > device trees stay valid; bumping the cell count unconditionally would > invalidate them. A second cell adds the direction, letting a DSI (TX) > and a CSI (RX) reference the same PHY node as separate consumers. > > Add include/dt-bindings/phy/rockchip,rk3588-mipi-dcphy.h for the > RK_DCPHY_DIR_TX and RK_DCPHY_DIR_RX direction constants. > > Signed-off-by: Jason Yang <[email protected]> > Assisted-by: Claude:claude-opus-4-8 LGTM Reviewed-by: Bryan O'Donoghue <[email protected]>