Re: [PATCH mvebu-dt64] arm64: dts: turris-mox: fix usb3 phys
Gregory CLEMENT <[email protected]>
| Newsgroups | gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi Tomáš Macholda,
> After commit 00e6d608fe80b0f6 ("arm64: dts: marvell: armada-37xx: swap
> PHYs' order in USB3 controller node") swapped USB3 PHY order, USB
> initialization breaks on Turris MOX.
>
> This regression was exposed by commit 91ddf6f722084383 ("phy: marvell:
> mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access") which
> made USB2 devices not work at all.
>
> Fix the issue by explicitly adding all USB3 PHYs and PHY names to
> Turris MOX device-tree.
>
> Fixes: 7109d817db2e ("arm64: dts: marvell: add DTS for Turris Mox")
> Signed-off-by: Tomáš Macholda <[email protected]>
Applied on mvebu/dt64
Thanks,
Gregory
> ---
> arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> index f4d73c8b1a6d..bd00e7df87c6 100644
> --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
> @@ -290,7 +290,8 @@ connector {
>
> &usb3 {
> status = "okay";
> - phys = <&comphy2 0>;
> + phys = <&usb2_utmi_otg_phy>, <&comphy2 0>;
> + phy-names = "usb2-phy", "usb3-phy";
> };
>
> &mdio {
> --
> 2.54.0
>
--
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com