Re: [PATCH 4/4] watchdog: aspeed: Propagate errors from optional IRQ lookup
Bui Duc Phuc <[email protected]>
| Newsgroups | gmane.linux.watchdog,gmane.linux.ports.arm.msm,gmane.linux.ports.arm.mediatek,gmane.linux.kernel,gmane.linux.ports.arm.kernel |
|---|---|
| Message-ID | <CAABR9nFy=GD4afdDxzsbp31Sq=smGVFf+HvqsrJKh_FjqdUrJA@mail.gmail.com> |
Hi Guenter,
Thank you for your review.
> > + if (irq < 0 && irq != -ENXIO)
> > + return irq;
> > if (irq > 0) {
>
> This if () is no longer needed.
>
If we remove the if (irq > 0) check, irq can be -ENXIO and would be
passed to devm_request_irq().
I see that the irq argument of devm_request_irq() is an unsigned int.
Would it be safe to pass -ENXIO to it in this case?
Best regards,
Phuc