Re: [PATCH v2 2/2] ipmi: kcs_bmc_aspeed: Support multiple LPC controller instances
YC Hsieh <[email protected]>
| Newsgroups | gmane.linux.kernel,gmane.linux.drivers.devicetree,gmane.linux.ports.arm.kernel,gmane.linux.kernel.openipmi |
|---|---|
| Message-ID | <TY0PR06MB68554A393BC5181EFB3BEA3D93A62@TY0PR06MB6855.apcprd06.prod.outlook.com> |
On Thu, Aug 13, 2026 at 02:42:32PM +0800, Yu-Che Hsieh wrote:
> > @@ -526,6 +528,17 @@ static int aspeed_kcs_of_get_channel(struct platform_device *pdev)
> > return -EINVAL;
> > }
> >
> > +static int aspeed_kcs_of_get_bank(struct device_node *lpc_np)
> > +{
> > + int id;
> > +
> > + id = of_alias_get_id(lpc_np, "lpc");
> NAK
> You do not get custom aliases.
Understood, thanks for the quick feedback.
I'll remove the alias and DT bindings patch in v3
and derive the bank index dynamically from the LPC
controller's device_node during the initial probe,
so no DT or binding changes are required.
Regards,
Yu-Che