Re: [PATCH v14 00/38] phy: rockchip: usbdp: Clean up the mess

On Thu, Aug 13, 2026 at 10:51:43PM +0200, Sebastian Reichel wrote:
> This series does a major overhaul of the Rockchip USBDP driver. The
> initial main goal was to add USB-C DP AltMode support to the RK3576
> and RK3588 and this series still prepares the PHY driver for exactly
> that. But in addition to that I uncovered a huge amount of issues,
> that are fixed along the way. Some of the more interesting ones are:
> 
>  * Currently the driver might trigger a fatal SError on USB-C hotplug,
>    since re-initializing the PHY stops the clocks going to DWC3. If
>    the DWC3 driver tries to access its registers at the same time the
>    system will crash.
>  * The DWC3 hardware can get into a buggy state when the PHY is
>    disabled, which results in the PHY not coming up properly again.
>  * Swithcing the USB-C connector orientation during hotplug breaks
>    USB3 speed, as the PHY is not being re-initialized.
>  * The code always enables DP mode when USB-C is involved.
>  * The driver has some locking issues uncovered by Sashiko.
> 
> In addition to these bigger ones, Sashiko also found a bunch of
> minor problems, which are mostly harmless, but were fixed while
> going at it.
> 

38 patches for a single series is too much to review. Please consider splitting
it up into multiple series not exceeding ~10 patches per series. Thanks!

- Mani

-- 
மணிவண்ணன் சதாசிவம்