Re: [PATCH] Common compat_sys_sysinfo (v2)
Arnd Bergmann <[email protected]>
| Newsgroups | gmane.linux.ports.hppa,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Monday 08 January 2007 00:43, Stephen Rothwell wrote:
> > +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> > +{
> > + struct sysinfo val;
> > +
> > + do_sysinfo(&val);
> >
> > - out:
> > if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> > return -EFAULT;
>
> People have complined before that this adds a whole stack frame to the
> "normal" syscall path. Personally I don't care, but it has been
> mentioned.
It might be a concern for something like 'read' which is called frequently
and in strange ways, but for 'sysinfo' this really should not matter.
Arnd <><