Re: [PARISC] fix uninitialized spinlock in HIL keyboard driver

On Sunday 18 February 2007, Dmitry Torokhov wrote:
> Hi Helge,
> 
> On Saturday 17 February 2007 17:21, Helge Deller wrote:
> > 
> > Can you drop this ^^ piece of this patch ?
> > Cyrill V. Gorcunov's (<[email protected]>) HP300 patches from a few days ago
> > are more correct since they include the release_region() call. 
> > 
> 
> I have 2 patches from Cyrill applied to my tree:
>  - one from couple days ago dealing with release_region() (2nd version that was
>    acked by you)
>  - another came to me throughg Andrew and deals with handling errors from
>    input_register_device(), request_region(), request_irq() + whitespace cleanup.
> 
> 
> > Or, if you want, I can resend this whole patch against your input-tree ?
> > Just let me know...
> > 
> 
> If you could redo the patches against my tree that would be nice - I am having
> trouble applying "[PARISC] hp_sdc: fix request_irq()/free_irq() parameters"
> 
> Btw, is there any chance we coudl fix the code style in hil drivers. They are
> very different from the rest of the kernel. Something like patch below...

Sure, I'll do both and send you seperate patches soon.

Helge